Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

[Kevin Ottens]

> On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote:
> > Tested the patch in my tree, works for caps lock too.
> > 
> > Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?
> 
> Martin Gräßlin wrote:
>     Then I would suggest to move this class to KWindowSystem for the moment. For the module KX11Extras I still need some code changes first (for some reason netwm is using KWindowSystem - it's wrong IMHO and needs fixing)

Well, if you remember it was my first choice to put KModifierKeyInfo in KWindowSystem, but you pushed back. :-)

I'm ok if you move it there then, looking forward to the patches. ;-)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112443/#review40510
-----------------------------------------------------------


On Sept. 4, 2013, 6:37 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112443/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 6:37 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Ported to native event filter and to xcb-xkb by reimplementing the events. Most parts are kept on xlib though as we don't have xkb.h to get proper defines.
> 
> 
> Diffs
> -----
> 
>   tier1/kguiaddons/CMakeLists.txt 3124c4d 
>   tier1/kguiaddons/src/lib/CMakeLists.txt dc6aafa 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_dummy.cpp 7913d29 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_p.h ee8e82e 
>   tier1/kguiaddons/src/lib/util/kmodifierkeyinfoprovider_x11.cpp 2f28d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112443/diff/
> 
> 
> Testing
> -------
> 
> used kmodifierkeyinfotest application. Would appreciate if someone else could run it as I don't have a caps lock.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/13313749/attachment.html>