Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

Kevin Ottens ervin at kde.org
Mon Sep 23 10:20:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112311/#review40511
-----------------------------------------------------------

Ship it!


Looks good. Any reason why it's not pushed yet? (got the first ship it two weeks ago).

- Kevin Ottens


On Sept. 2, 2013, 3:13 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112311/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Title says it all
> 
> 
> Diffs
> -----
> 
>   kio/kio/kmimetypechooser.cpp 616b033 
> 
> Diff: http://git.reviewboard.kde.org/r/112311/diff/
> 
> 
> Testing
> -------
> 
> Tested by running kmimetypechoosertest, the behavior is same with or without this patch.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/30876bf1/attachment.html>


More information about the Kde-frameworks-devel mailing list