Review Request 112367: Include the icon's theme in the cache key

[Kevin Ottens]

> On Aug. 31, 2013, 7:11 a.m., David Faure wrote:
> > I disagree. Making things slow to cover a really really corner case (mixing kde4 and kde5), while the solution already exists (clearing the cache when switching icon themes), doesn't seem very sensible to me.
> > 
> > The point is really that you can only use one icon theme at a time.
> 
> Àlex Fiestas wrote:
>     While it is a corner case I think we should find a solution to make this more solid.
>     Perhaps we could set the theme name in the cache, and then check if it has changed, if so remove cache.
>     
>     What is a bug imho is that theme can be changed without the cache getting cleaned somehow, corner case if you want but a bug.
> 
> David Faure wrote:
>     There's a *lot* of things that break if you run two separate DBus sessions and do things in one session and expect the other session to react. IMHO it's actually a feature that this isn't the case ;)
>     
>     But indeed we get into bugs when we have such "broken dbus communication" because of using two sessions, but these two sessions share some files, e.g. config files. Because then they see the changed files at some point, but didn't get change notification.
>     
>     However fixing all such occurences is a HUGE amount of work, and it's not worth it IMHO.
>     
>     But first, am I right that this is the case you're having? Different dbus sessions between your kde4 and kde5 code, but shared config files? (or symlinks, if the chosen icon theme is a symlink - I forgot how that works exactly)
> 
> Àlex Fiestas wrote:
>     I think it is much simpler than that:
>     -Theme is changed but cache is not nuked, we get wrong icons.
>     
>     My case is, KIconLoader should realize that the theme has changed and nuke it without any external help.
>     
>     What is happening is, that KSharedDataCache::deleteCache("icon-cache"); is removing the cache from KDE4 (in /tmp/... I guess) instead of using the new standard paths which is what it should do.

Are you sure about that? It uses QStandardPaths internally...


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112367/#review38986
-----------------------------------------------------------


On Aug. 29, 2013, 8 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112367/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 8 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> If we make no difference between an icon from oxygen and an icon from
> gnome, when we change themes for example from oxygen to gnome, the
> icon will be found in the cache and won't be upgraded.
> 
> 
> Diffs
> -----
> 
>   kdeui/icons/kiconloader.cpp ce6aeea 
> 
> Diff: http://git.reviewboard.kde.org/r/112367/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130923/a70e0fac/attachment.html>