Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

[David Faure]

> On Sept. 19, 2013, 7:48 a.m., David Faure wrote:
> > staging/kemoticons/src/core/kemoticons.cpp, line 110
> > <http://git.reviewboard.kde.org/r/112808/diff/1/?file=190507#file190507line110>
> >
> >     This test is already done internally in QFSW, remove it from here.
> 
> Aleix Pol Gonzalez wrote:
>     But then, it keeps outputting that it's already in, doesn't it? At least on Qt4 it does.

Hmm, you're right about Qt4:

QWARN  : tst_QFileSystemWatcher::addPath() QFileSystemWatcher: failed to add paths: /home/dfaure

Same test doesn't warn on Qt5.
ecb57cfc32ebbc457fd5e58ae0efc4dcb9d4d3f8 removed that warning, and replaced it with "reporting errors to the caller".


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40325
-----------------------------------------------------------


On Sept. 19, 2013, 8:37 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112808/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2013, 8:37 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port away from KDirWatch in KEmoticons (prior to splitting)
> 
> 
> Diffs
> -----
> 
>   staging/kemoticons/src/core/CMakeLists.txt 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
>   staging/kemoticons/src/core/kemoticons.cpp 5f6a23ec606b3c6dceac2e01a280413e6899a59b 
> 
> Diff: http://git.reviewboard.kde.org/r/112808/diff/
> 
> 
> Testing
> -------
> 
> It builds and installs correctly.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130921/deeaf5a4/attachment.html>