Review Request 112840: Port from kde4_add_plugin to add_library

Aleix Pol Gonzalez aleixpol at kde.org
Fri Sep 20 15:06:44 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112840/
-----------------------------------------------------------

Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.


Description
-------

After the recent changes we can safely change kde4_add_plugin -> add_library


Diffs
-----

  KDE5PORTING.html 65fcf6e 
  interfaces/kmediaplayer/kfileaudiopreview/CMakeLists.txt b32b816 
  kdewidgets/CMakeLists.txt b75f810 
  kfile/CMakeLists.txt 0475bf2 
  khtml/CMakeLists.txt bbaa4bb 
  khtml/java/CMakeLists.txt a9e5abf 
  khtml/kmultipart/CMakeLists.txt aa62156 
  kio/kssl/kcm/CMakeLists.txt 88f4479 
  kio/misc/kpac/CMakeLists.txt 8753923 
  kioslave/help/CMakeLists.txt 4a5f6ae 
  kioslave/http/CMakeLists.txt faf4b5a 
  kioslave/http/kcookiejar/CMakeLists.txt 62aa05e 
  kparts/tests/CMakeLists.txt 0e9b2b2 
  kross/kjs/CMakeLists.txt 22dec92 
  kross/modules/CMakeLists.txt fa5cc10 
  kross/qts/CMakeLists.txt d575c6d 
  staging/kde4support/src/kioslave/metainfo/CMakeLists.txt c96a3f6 
  staging/kemoticons/src/providers/adium/CMakeLists.txt 2a937f5 
  staging/kemoticons/src/providers/kde/CMakeLists.txt 02254f0 
  staging/kemoticons/src/providers/pidgin/CMakeLists.txt f98e137 
  staging/kemoticons/src/providers/xmpp/CMakeLists.txt 54975e2 
  staging/kio/src/kssld/CMakeLists.txt e64f491 
  staging/kio/src/widgets/thumbcreator.h f18cd84 

Diff: http://git.reviewboard.kde.org/r/112840/diff/


Testing
-------

Builds, nothing seem to have changed.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130920/bf0cd41e/attachment.html>


More information about the Kde-frameworks-devel mailing list