Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
Àlex Fiestas
afiestas at kde.org
Thu Sep 19 15:25:02 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112823/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 3:25 p.m.)
Review request for KDE Frameworks and Aurélien Gâteau.
Changes
-------
Fixed all opened issues.
Description
-------
Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG.
As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath.
Diffs (updated)
-----
KDE5PORTING.html c1dde0a
knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d
knewstuff/src/ui/progressindicator.cpp 1ca9478
staging/kiconthemes/autotests/CMakeLists.txt 1e5899f
staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c
staging/kiconthemes/src/CMakeLists.txt 0de6456
staging/kiconthemes/src/kiconloader.h 65346df
staging/kiconthemes/src/kiconloader.cpp 36a61a1
staging/kiconthemes/src/kpixmapsequence.h ef94596
staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1
staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82
staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74
staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17
staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c
staging/kiconthemes/tests/CMakeLists.txt 855d45d
staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h
staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c
tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b
tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2
tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112823/diff/
Testing
-------
Thanks,
Àlex Fiestas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/25b52af7/attachment.html>
More information about the Kde-frameworks-devel
mailing list