Review Request 112681: Tests for KPluginTrader and friends

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112681/#review40331
-----------------------------------------------------------


This review has been submitted with commit afcaf264cb5417fea36e8688f5c5579e0226fb12 by Sebastian Kügler to branch frameworks.

- Commit Hook


On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112681/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 12:12 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Tests for KPluginTrader.
> 
> Under autotests/, there's a new test class which runs a variety of queries using KPluginTrader. There's also a small plugin, which is used to verify correct metadata querying and loading. It's not installed since QPluginLoader conveniently contains the working directory when looking for plugins -> it's found just fine.
> 
> Under tests/, there's a test which will query for a variety of other plugins. This one is more geared towards performance testing. When run from make test, it will pass anyway.
> 
> Code can also be found in kdelibs[sebas/pluginlocator].
> 
> 
> Diffs
> -----
> 
>   staging/kservice/autotests/CMakeLists.txt d341040 
>   staging/kservice/autotests/fakeplugin.desktop PRE-CREATION 
>   staging/kservice/autotests/fakeplugin.json PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.h PRE-CREATION 
>   staging/kservice/autotests/nsaplugin.cpp PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.h PRE-CREATION 
>   staging/kservice/autotests/pluginlocatortest.cpp PRE-CREATION 
>   staging/kservice/tests/CMakeLists.txt 3793aea 
>   staging/kservice/tests/pluginlocator/CMakeLists.txt PRE-CREATION 
>   staging/kservice/tests/pluginlocator/main.cpp PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.h PRE-CREATION 
>   staging/kservice/tests/pluginlocator/plugintest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112681/diff/
> 
> 
> Testing
> -------
> 
> make test =)
> 
> All tests pass on top of my patches.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/626422b3/attachment.html>