Review Request 112803: Start cleaning up KDNSSD

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112803/#review40324
-----------------------------------------------------------



dnssd/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112803/#comment29762>

    not exactly



dnssd/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112803/#comment29761>

    not useful, we don't set it anymore
    (such a line should probably be removed all over kdelibs)



dnssd/CMakeLists.txt
<http://git.reviewboard.kde.org/r/112803/#comment29760>

    this line is missing LINK_PUBLIC or LINK_PRIVATE (I would guess the latter?)


- David Faure


On Sept. 18, 2013, 6:41 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112803/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 6:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Renames target to KDNSSD.
> Properly look-up Qt and KF5.
> 
> After that I'll move it to staging.
> 
> 
> Diffs
> -----
> 
>   dnssd/CMakeLists.txt 7f2620a 
> 
> Diff: http://git.reviewboard.kde.org/r/112803/diff/
> 
> 
> Testing
> -------
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130919/b58f6da1/attachment.html>