Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

Aleix Pol Gonzalez aleixpol at kde.org
Wed Sep 18 22:58:06 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112808/#review40316
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112808/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port away from KDirWatch in KEmoticons (prior to splitting)
> 
> 
> Diffs
> -----
> 
>   staging/kemoticons/src/core/CMakeLists.txt 0e79eaae60dfd5cd5e0c5f6848b86dbb90c0c818 
>   staging/kemoticons/src/core/kemoticons.cpp 5f6a23ec606b3c6dceac2e01a280413e6899a59b 
> 
> Diff: http://git.reviewboard.kde.org/r/112808/diff/
> 
> 
> Testing
> -------
> 
> It builds and installs correctly.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130918/54de9558/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list