Review Request 112519: trim KStyle

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review40252
-----------------------------------------------------------

Ship it!


What exactly is the plan for "KStyle 3/3"? I see many more cruft that could be removed for the KF5 version, in particular, all the enums. If that's the idea, please ship this in the meantime.


staging/frameworkintegration/src/kstyle/kstyle.cpp
<http://git.reviewboard.kde.org/r/112519/#comment29739>

    Could you check the diff on reviewboard site? Here, I see many red "whitespace" issues now.


- Christoph Feck


On Sept. 17, 2013, 1:54 p.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112519/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Hugo Pereira Da Costa.
> 
> 
> Description
> -------
> 
> KStyle 2/3: Remove everything from KStyle which is not a reimplementation of the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, standardIcons.
> 
> 
> Note:
> Probably we can remove drawKStylePrimitive (and a lot enums/structs in kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter correctly and this is material for 3/3 KStyle task :)
> 
> 
> Diffs
> -----
> 
>   staging/frameworkintegration/src/kstyle/kstyle.h a3061d3 
>   staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41 
> 
> Diff: http://git.reviewboard.kde.org/r/112519/diff/
> 
> 
> Testing
> -------
> 
> It builds and tests looks OK
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/fa533729/attachment.html>