Review Request 112772: Create an ecm_mark_as_autotest macro

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112772/#review40240
-----------------------------------------------------------


The macro does more than the name implies, additionally to marking it as test it also actually adds the test.
So I'd prefer a different name.

Having said that, the CMakeLists.txt in the various tests/ subdirs in KDE frameworks look all quite similar, they more or less all feature a quite similar macro, foo_unit_tests(). Maybe a more advanced function can be written which can be used in all those places ?

- Alexander Neundorf


On Sept. 17, 2013, 12:35 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112772/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 12:35 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Description
> -------
> 
> Creates a function that will define a unit test with the project name (like it's being done in KF5) and calls ecm_mark_as_test.
> 
> This should help simplify the tests creation that at the moment is quite verbose.
> 
> 
> Diffs
> -----
> 
>   modules/ECMMarkAsTest.cmake f1e53e4 
> 
> Diff: http://git.reviewboard.kde.org/r/112772/diff/
> 
> 
> Testing
> -------
> 
> Ported some tests in KF5, it worked.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/39da33f9/attachment.html>