Review Request 112730: Make knewstuff build standalone

[David Faure]

> On Sept. 17, 2013, 8:05 a.m., Chusslove Illich wrote:
> > knewstuff/src/downloaddialog.cpp, line 35
> > <http://git.reviewboard.kde.org/r/112730/diff/1/?file=189543#file189543line35>
> >
> >     Technically it is possible to mix translation frameworks, but I see no point
> >     to that. Certainly not because some piece of the build system gone stale. So
> >     yes, there should be a prepared way to apply uic with the options as in KDE
> >     4. It is also logical for this now to be part of ki18n. Maybe located in
> >     ki18n/buildsys/cmake/, in case later some other build system gets support.
> >

Agreed (except the path: the standard framework layout mandates ki18n/cmake/).

Jeremy, can you take care of it?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/#review40194
-----------------------------------------------------------


On Sept. 17, 2013, 7:29 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112730/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2013, 7:29 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Chusslove Illich.
> 
> 
> Description
> -------
> 
> This makes it so I can mkdir build; cd build; cmake ../; make install from knewstuff sources.
> It's still using KDE4_KIO_LIBS and find_package(KIO) since not all of the kio libraries have been split out apparently.
> I'm not sure why sources had to be changed, but I had to add includes of klocalizedstring where we didn't need them before somehow.
> 
> 
> Diffs
> -----
> 
>   knewstuff/CMakeLists.txt 3fccbc6ee01a1cc8920321ee7125efb0bfc68412 
>   knewstuff/src/CMakeLists.txt c31398159459b79160ef76f193d6208d19953b4d 
>   knewstuff/src/downloaddialog.cpp 3294c7c04c7879320fc0949db0310868bd6fa4fa 
>   knewstuff/src/downloadwidget.cpp 64b7673d67b4e2f15007fc1a3f57d3da844d1dc0 
>   knewstuff/src/ui/entrydetailsdialog.cpp 65b75d79941d9026f368f82c7b6df91d754e0925 
>   knewstuff/src/uploaddialog.cpp dbde573e8c3a477755c8c866d0ca1fccd1a35729 
> 
> Diff: http://git.reviewboard.kde.org/r/112730/diff/
> 
> 
> Testing
> -------
> 
> It builds and installs.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/98886d27/attachment.html>