Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112755/
-----------------------------------------------------------

(Updated Sept. 17, 2013, 7:42 a.m.)


Review request for KDE Frameworks.


Changes
-------

* verify mask is a bitmap
* verify mask has same size as the pixmap
* specify bytes per line when creating the image
* try to get the format from the ximage depth (tested with 1 and 24 - xclock used for the bitmap case, looks strange to be honest)


Description
-------

Implements the createPixmapFromHandle by getting the image for the pixmaps and using it as either the Pixmap or the bitmap mask.


Diffs (updated)
-----

  tier1/kwindowsystem/src/kxutils.cpp 33bd678 
  tier1/kwindowsystem/src/kxutils_p.h 84d639b 

Diff: http://git.reviewboard.kde.org/r/112755/diff/


Testing
-------

Adjusted KWin to take this codepath and say thanks to Iceweasel for having a mask


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/343e4854/attachment.html>