Review Request 112662: Clean up CMakeLists.txt and prepare for splitting KEmoticons

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112662/#review40186
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Sept. 15, 2013, 12:27 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112662/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 12:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> Clean up CMakeLists.txt and prepare for splitting KEmoticons
> 
> 
> Diffs
> -----
> 
>   staging/kemoticons/CMakeLists.txt 5e332b0e7486a7f20afc85f20b43d87a9c536177 
>   staging/kemoticons/KEmoticonsConfig.cmake.in PRE-CREATION 
>   staging/kemoticons/src/core/CMakeLists.txt f8c20c9a7e2f139fad358c38e7108f06863e0bf5 
>   staging/kemoticons/src/providers/adium/CMakeLists.txt a1c503f26dfbac0bf80f0d42b8fa4db8bfbfb88a 
>   staging/kemoticons/src/providers/kde/CMakeLists.txt 20fda61670bcaa8d5d5e5974c9ab3a85099b5e29 
>   staging/kemoticons/src/providers/xmpp/CMakeLists.txt 6615cf59a987389606243715ad89283a887329da 
>   staging/kemoticons/tests/CMakeLists.txt 5e0d46ed03e23ea31dc6c1b9a74b69ec601ebbc3 
> 
> Diff: http://git.reviewboard.kde.org/r/112662/diff/
> 
> 
> Testing
> -------
> 
> It builds. Test passes.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/5a68a052/attachment.html>