Review Request 112583: Steps to make KConfigWidgets compile Standalone

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/#review40184
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On Sept. 16, 2013, 11:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112583/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 11:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> KConfigWidgets relies on a private header in KWidgetAddons. This prevents KConfigWidgets building on it's own
> 
> By exposing the two of these private members in protected methods, we can solve this problem.
> 
> 
> Commit log below:
> --------------
> 
> change target link libraries to ${lib_LIBRARIES} format
> --
> 
> Remove inheritance on KSelectionActionPrivate in KRecentFileActions
> 
> This is in a different framework so cannot be used when building
> standalone.
> 
> --
> Expose associated comboboxes and toolbuttons in KSelectAction
> 
> 
> Diffs
> -----
> 
>   staging/kconfigwidgets/src/krecentfilesaction.h edf77a2 
>   staging/kconfigwidgets/src/krecentfilesaction.cpp 9aa5f8b 
>   staging/kconfigwidgets/src/krecentfilesaction_p.h 8b3cc8f 
>   tier1/kwidgetsaddons/src/kselectaction.h 07afaa9 
>   tier1/kwidgetsaddons/src/kselectaction.cpp 3aa0797 
> 
> Diff: http://git.reviewboard.kde.org/r/112583/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130917/26c5c64d/attachment.html>