Review Request 112759: sonnet - improve dependencies

[Michael Palimaka]

> On Sept. 16, 2013, 5:21 p.m., Aleix Pol Gonzalez wrote:
> > tier1/sonnet/autotests/CMakeLists.txt, line 5
> > <http://git.reviewboard.kde.org/r/112759/diff/1/?file=189910#file189910line5>
> >
> >     Seems like you should use "${REQUIRED_QT_VERSION}" here too... no?

I set it like this for consistency, since the vast majority of existing non-root find_dependency calls are like that (for whatever reason). Should this change be made globally then?


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112759/#review40171
-----------------------------------------------------------


On Sept. 16, 2013, 5:12 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112759/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2013, 5:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move QtTest out of the project root, and remove QtDBus and QtXml to which there are no references.
> 
> 
> Diffs
> -----
> 
>   tier1/sonnet/CMakeLists.txt 07935a60d3420efc22f9c5d392130aec2900eeb5 
>   tier1/sonnet/autotests/CMakeLists.txt 91755f3f2cc3fa38cdec2b048337432398e16f1d 
> 
> Diff: http://git.reviewboard.kde.org/r/112759/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130916/203d3f87/attachment.html>