Review Request 112681: Tests for KPluginTrader and friends

Sebastian Kügler sebas at kde.org
Mon Sep 16 09:50:21 UTC 2013


On Sunday, September 15, 2013 08:42:31 David Faure wrote:
> Data-driven tests *can* be run separately (and therefore qDebugs don't get
> confusing), using the "methodName:rowName" syntax as command-line argument.
> 
> Data-driven tests have the huge benefit that they reduce code duplication,
> and they make it a lot easier to add new tests (which means people tend to
> do it a lot more than with procedural tests).
> 
> I don't see which test "looks for a magic string in the plugin", in this
> change request all methods except the last one could easily be factorized,
> they perform the exact same steps with different data (and different
> expected result).
> 
> If this was Qt I'm pretty sure you'd be required to convert it to
> data-driven. But this is KDE, so I'll let you decide (now that you have all
> the data...).

I'm not sure I understand it well. Do you have an example?
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9


More information about the Kde-frameworks-devel mailing list