Review Request 112716: Prepare itemviews for moving

Commit Hook null at kde.org
Mon Sep 16 09:20:09 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112716/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 9:20 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
-------

- Use REQUIRED_QT_VERSION in CMakeLists and ItemViewsConfig.cmake.in
- Add dependency on KCoreAddons (which will go away when we can use QCollator)

This review replace my previous version, which also moved the itemviews/ dir to tier2. This is not good because if/when we can use QCollator the dependency on KCoreAddons can be dropped and ItemViews can be a tier1 framework.


Diffs
-----

  staging/itemviews/CMakeLists.txt f5c3c8d 
  staging/itemviews/ItemViewsConfig.cmake.in c10f49f 

Diff: http://git.reviewboard.kde.org/r/112716/diff/


Testing
-------

Builds within kdelibs and standalone.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130916/f352f1ab/attachment.html>


More information about the Kde-frameworks-devel mailing list