Review Request 112702: KIO slavebase listEntry improvement and cleanups

Commit Hook null at kde.org
Sun Sep 15 15:00:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112702/#review40070
-----------------------------------------------------------


This review has been submitted with commit 61815341d9761068e3c08a84b4d3ae7b2196a998 by Mark Gaiser to branch frameworks.

- Commit Hook


On Sept. 14, 2013, 10:36 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112702/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2013, 10:36 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> This patch actually does two things:
> 1. A small indentation fix that this diff doesn't show properly (i can commit that as a separate commit if that's preferred)
> 2. A cleanup in how a listDir is handled. It used to be required to send a listEntry(UDSEntry, true) to indicate that the listing is completed. Then the UDSEntry was skipped. It seemed vague to me so i deprecated that function and added a new listEntry that doesn't take a bool. Now you just have to call finished() when done listing. finished() was already required otherwise KIO would blame you with warnings :)
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file_unix.cpp 48bd0ba 
>   staging/kio/src/core/slavebase.h b46631e 
>   staging/kio/src/core/slavebase.cpp 2e46985 
> 
> Diff: http://git.reviewboard.kde.org/r/112702/diff/
> 
> 
> Testing
> -------
> 
> It compiles and runs just fine. The few tests that are there are passing though i doubt they test this case. the KIO file slave also works just fine. Compilation does give me new (expected_ deprecated errors for at least the http slave. I don't know how to test that one. It should just work fine though.
> 
> 
> File Attachments
> ----------------
> 
> Updated diff
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/14/kioslave_listentry_improvement.patch
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130915/c437967e/attachment.html>


More information about the Kde-frameworks-devel mailing list