Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112673/#review39985
-----------------------------------------------------------


This review has been submitted with commit e8e401e317c4bd526a890a87687b75a14aeefc8e by David Edmundson to branch frameworks.

- Commit Hook


On Sept. 11, 2013, 4:52 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112673/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2013, 4:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Expose setStandardActionNames as public API in kacceleratormanager
> 
> This is needed by KStandardAction which is in a different tier to
> kacceleratormanager.
> 
> I changed it from setStandardActionNames to addStandardActionNames as
> now it it public API it shouldn't break if two classes use it.
> 
> 
> Diffs
> -----
> 
>   staging/kconfigwidgets/src/kstandardaction.cpp 23e3b32 
>   tier1/kwidgetsaddons/src/kacceleratormanager.h 108cb85 
>   tier1/kwidgetsaddons/src/kacceleratormanager.cpp f50057e 
>   tier1/kwidgetsaddons/src/kacceleratormanager_p.h 89ccde5 
> 
> Diff: http://git.reviewboard.kde.org/r/112673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/b133af9b/attachment.html>