Review Request 112685: Fix KWindowSystem::setMainWindow
Commit Hook
null at kde.org
Fri Sep 13 15:25:03 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 3:25 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Martin Gräßlin.
Description
-------
Due to changes in the way Qt5 handles windows, old code was not working
anymore (Qt::WA_X11BypassTransientForHint attribute is ignored by Qt5).
New code takes advantage of Qt5 support for handling foreign windows
provided by QWindow::fromWinId().
Diffs
-----
tier1/kwindowsystem/CMakeLists.txt 3db68d5
tier1/kwindowsystem/src/kwindowsystem_x11.cpp bcfaf17
tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION
tier1/kwindowsystem/tests/setmainwindowtest.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/112685/diff/
Testing
-------
Added a new manual test.
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/5b3477ca/attachment.html>
More information about the Kde-frameworks-devel
mailing list