Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

Commit Hook null at kde.org
Fri Sep 13 13:42:02 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112684/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 1:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Aurélien Gâteau.


Description
-------

updateUserTimestamp() used to fetch the current time by creating a property notify event and wait till it is received by inspecting the XEvent queue. That doesn't work with XCB anymore, but Qt provides this functionality for us, so just use that.

At the same time the argument is changed from int to unsigned long as that's what the method in QX11Info returns.


Diffs
-----

  staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 
  staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f 

Diff: http://git.reviewboard.kde.org/r/112684/diff/


Testing
-------

compiles.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/5a809bb3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list