Review Request 112710: Move KIO::NetAccess to kde4support

Àlex Fiestas afiestas at kde.org
Fri Sep 13 11:21:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112710/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Description
-------

Move KIO::NetAccess to kde4support.

I have also added @deprecated to all the functions that did not have with the exception of fish_execute that I'm unsure if we want to provide an alternative for that (since it will always be dependent on a slave...).

Also, I haven't added KDE4SUPPORT_DEPREACTED_EXPORT to all methods, that would add too much noise when compiling other modules... we have to find a better solution to deprecate all kde4support.


Diffs
-----

  kio/CMakeLists.txt d44dcc2 
  kio/kio/netaccess.h 11a4ac9 
  kio/kio/netaccess.cpp  
  kio/tests/CMakeLists.txt 1874712 
  kio/tests/fileundomanagertest.cpp 5f5fb27 
  kio/tests/jobguitest.cpp ec65942 
  kio/tests/jobremotetest.cpp ce99ff4 
  kio/tests/kdirmodeltest.cpp 256d32e 
  kio/tests/netaccesstest.cpp  
  staging/kde4support/src/CMakeLists.txt 466c195 
  staging/kde4support/tests/CMakeLists.txt 2c38f46 

Diff: http://git.reviewboard.kde.org/r/112710/diff/


Testing
-------


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/c29addf8/attachment.html>


More information about the Kde-frameworks-devel mailing list