Review Request 112689: Drop KI18n dependencies in KCompletion

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112689/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 11:01 a.m.)


Review request for KDE Frameworks.


Changes
-------

Properly use tr() as a replacement for i18nc()


Description
-------

It's not really adding much value here, so I'd say we can drop it.

I'm not sure that tr() is as well the correct replacement for i18nc(), can anybody confirm?


Diffs (updated)
-----

  staging/kcompletion/src/CMakeLists.txt dd9d99c 
  staging/kcompletion/src/kcombobox.cpp 8a73a1b 
  staging/kcompletion/src/khistorycombobox.cpp 2e53bd9 
  staging/kcompletion/src/klineedit.cpp 76ef377 
  staging/knotifications/CMakeLists.txt 2e42ab3 

Diff: http://git.reviewboard.kde.org/r/112689/diff/


Testing
-------

builds, tests pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/10b7ba72/attachment.html>