Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

[Aleix Pol Gonzalez]

> On Sept. 13, 2013, 7:35 a.m., David Faure wrote:
> > See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt.
> > 
> > This is preparation for future splitting. The variables are necessary for that, for now, as I understand it.
> > 
> > Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :)

Well, then it shouldn't matter, because it makes the modules less inter-dependent.

At the moment we're relying too much about things defined in kdelibs/CMakeLists.txt and we're having things defined in weird ways, IMHO.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112697/#review39936
-----------------------------------------------------------


On Sept. 13, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112697/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:33 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly.
> 
> 
> Description
> -------
> 
> move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again.
> 
> It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables.
> 
> In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 17f1b46 
>   tier2/kauth/autotests/CMakeLists.txt ff0feb0 
>   tier2/kauth/src/CMakeLists.txt 31f0f9c 
>   tier2/kcrash/src/CMakeLists.txt f340acd 
> 
> Diff: http://git.reviewboard.kde.org/r/112697/diff/
> 
> 
> Testing
> -------
> 
> Still builds.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/5443fb0e/attachment.html>