Review Request 112660: KPluginInfo rework for KPluginTrader

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112660/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 7:07 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

* Changed keys to static const char[], used s_camelCaseKey for their names
* Added libraryPath = QString() in the args-based ctor (from other review)
* Coding style++


Description
-------

This patch prepares KPluginInfo for usage with KPluginTrader (to be submitted in a separate patch). It basically makes KPluginInfo's API a little bit more like KService by adding a property(QString) accessor to the plugin info. This allows us on the one hand 

Part of this patch, and much of its churn, is the internal change from independent QStrings and QStringLists to a QVariantMap. This is how the metadata comes in from KPlugin*, and it allows us to make properties accessible by name.

There's also a fair bit of moving from QLatin1String to QStringLiteral in there, most of these lines needed changes anyway. Additionally, the keys of properties are now shared in the d-pointer.

This change is source compatible to the old version.


Diffs (updated)
-----

  staging/kservice/src/services/kplugininfo.h c2e5bab 
  staging/kservice/src/services/kplugininfo.cpp 21e0882 

Diff: http://git.reviewboard.kde.org/r/112660/diff/


Testing
-------

All tests still pass, no regressions encountered otherwise.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130912/eac23f76/attachment-0001.html>