Review Request 112685: Fix KWindowSystem::setMainWindow

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112685/#review39884
-----------------------------------------------------------



tier1/kwindowsystem/src/kwindowsystem_x11.cpp
<http://git.reviewboard.kde.org/r/112685/#comment29440>

    do we need that assert here?



tier1/kwindowsystem/src/kwindowsystem_x11.cpp
<http://git.reviewboard.kde.org/r/112685/#comment29441>

    who cleans up the QWindow pointer? Looks to me like it will leak. Maybe try to wrap it in a QScopedPointer, once the setTransientParent is called we hopefully don't need the window around any more.



tier1/kwindowsystem/src/kwindowsystem_x11.cpp
<http://git.reviewboard.kde.org/r/112685/#comment29442>

    Looks like I need to look at this one. KXErrorHandler is evil code.


- Martin Gräßlin


On Sept. 12, 2013, 3:56 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112685/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 3:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Due to changes in the way Qt5 handles windows, old code was not working
> anymore (Qt::WA_X11BypassTransientForHint attribute is ignored by Qt5).
> 
> New code takes advantage of Qt5 support for handling foreign windows
> provided by QWindow::fromWinId().
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/CMakeLists.txt 3db68d5 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp bcfaf17 
>   tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION 
>   tier1/kwindowsystem/tests/setmainwindowtest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112685/diff/
> 
> 
> Testing
> -------
> 
> Added a new manual test.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130912/bdcf666b/attachment-0001.html>