Review Request 112682: move solid/networking_win.cpp to tier1/solid

Commit Hook null at kde.org
Thu Sep 12 14:20:47 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112682/#review39885
-----------------------------------------------------------


This review has been submitted with commit acd9009eb4d8d431cdb14c4916233c07db368f11 by Wojciech Kapuscinski to branch frameworks.

- Commit Hook


On Sept. 12, 2013, 11:28 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112682/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 11:28 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> simple move from solid to tier1/solid
> 
> I'm not sure why this file is still in wrong place.
> 
> from tier1/solid/src/solid/CMakeLists.txt
> 
> if(WIN32)
>    set(solid_LIB_SRCS networking_win.cpp)
> else()
>    set(solid_LIB_SRCS networking.cpp)
> endif()
> 
> So it looks like someone forgot move this file?
> 
> 
> Diffs
> -----
> 
>   solid/solid/networking_win.cpp  
> 
> Diff: http://git.reviewboard.kde.org/r/112682/diff/
> 
> 
> Testing
> -------
> 
> It builds on linux
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130912/559f451a/attachment.html>


More information about the Kde-frameworks-devel mailing list