Review Request 112583: Steps to make KConfigWidgets compile Standalone
David Edmundson
david at davidedmundson.co.uk
Wed Sep 11 17:06:13 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112583/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 5:06 p.m.)
Review request for KDE Frameworks.
Description
-------
KConfigWidgets relies on a private header in KWidgetAddons. This prevents KConfigWidgets building on it's own
By exposing the two of these private members in protected methods, we can solve this problem.
Commit log below:
--------------
change target link libraries to ${lib_LIBRARIES} format
--
Remove inheritance on KSelectionActionPrivate in KRecentFileActions
This is in a different framework so cannot be used when building
standalone.
--
Expose associated comboboxes and toolbuttons in KSelectAction
Diffs (updated)
-----
staging/kconfigwidgets/src/CMakeLists.txt dad6bcc140cb4fe56380bd44ea007fe1f06edace
staging/kconfigwidgets/src/krecentfilesaction.h edf77a24866018134d9c5a200c6e35213742c555
staging/kconfigwidgets/src/krecentfilesaction.cpp 9aa5f8bd83d064402dd6333c7cd89a388d373fe1
staging/kconfigwidgets/src/krecentfilesaction_p.h 8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c
tier1/kwidgetsaddons/src/kselectaction.h 07afaa960d2be4877aeef0ff074d0fd20c7b7f40
tier1/kwidgetsaddons/src/kselectaction.cpp 3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e
Diff: http://git.reviewboard.kde.org/r/112583/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130911/ac074bb1/attachment.html>
More information about the Kde-frameworks-devel
mailing list