Review Request 112643: Adapt KCompletion so that it can be moved to tier2

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112643/#review39778
-----------------------------------------------------------

Ship it!


Though I would put the remove_definitions changes in a separate patch.

Thanks!

- Stephen Kelly


On Sept. 10, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112643/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 6:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Description
> -------
> 
> Adds the dependencies in the Config.cmake.in file.
> Properly sets the Qt version dependency.
> Puts all the remove_definitions together.
> 
> 
> Diffs
> -----
> 
>   staging/kcompletion/CMakeLists.txt b498ae9 
>   staging/kcompletion/KCompletionConfig.cmake.in 53b6219 
>   staging/kcompletion/src/CMakeLists.txt 5e8ae19 
> 
> Diff: http://git.reviewboard.kde.org/r/112643/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/a532ca78/attachment.html>