Review Request 112545: Unify both meinproc5 binaries

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 10 16:52:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112545/
-----------------------------------------------------------

(Updated Sept. 10, 2013, 4:52 p.m.)


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

implement david's suggestions.


Description
-------

Now we only have the one, which can be compiled without KArchive by ifdef'ing meinproc.cpp.

I'm unsure that KArchive it's that big of a dependency, to make it optional. Opinions?


Diffs (updated)
-----

  staging/kdoctools/src/CMakeLists.txt 72bb06e 
  staging/kdoctools/src/meinproc.cpp 5d476f6 
  staging/kdoctools/src/meinproc_simple.cpp 334f13f 

Diff: http://git.reviewboard.kde.org/r/112545/diff/


Testing
-------

Builds, both ways.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/1525d30a/attachment.html>


More information about the Kde-frameworks-devel mailing list