Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs
David Faure
faure at kde.org
Tue Sep 10 14:34:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39721
-----------------------------------------------------------
Ship it!
khtml/html/html_formimpl.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29246>
same here. oh well :)
khtml/khtml_part.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29245>
I just realized that KIO::storedGet + job->exec() would remove the need for a temporary file altogether :-)
But OK leave it as that if you want to move on.
- David Faure
On Sept. 10, 2013, 1:56 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112559/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 1:56 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Description
> -------
>
> Port the rest of kdelibs-frameworks to KIO/Jobs
>
>
> Diffs
> -----
>
> khtml/ecma/xmlhttprequest.h 6edf708
> khtml/ecma/xmlhttprequest.cpp 565b489
> khtml/html/html_formimpl.cpp 1a16a77
> khtml/khtml_part.cpp 1833e4c
> kio/kfile/kpropertiesdialog.cpp 2d2f00e
> kross/ui/plugin.cpp f9f23f9
>
> Diff: http://git.reviewboard.kde.org/r/112559/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/3360714d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list