Review Request 112281: Allow setting a custom highligher on the spell check decorator
Aurélien Gâteau
agateau at kde.org
Tue Sep 10 13:01:07 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/#review39719
-----------------------------------------------------------
Ship it!
Looks good to me. Thanks for taking care of adding the doc I did not write.
- Aurélien Gâteau
On Sept. 8, 2013, 10:54 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112281/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2013, 10:54 a.m.)
>
>
> Review request for KDE Frameworks and Aurélien Gâteau.
>
>
> Description
> -------
>
> Allow setting a custom highlighter on the spell check decorator
>
> --
>
> This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter.
> This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit.
>
>
> Diffs
> -----
>
> tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d
> tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966
>
> Diff: http://git.reviewboard.kde.org/r/112281/diff/
>
>
> Testing
> -------
>
> None - my KF5 setup has no dictionaries installed.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/6bb12fc7/attachment.html>
More information about the Kde-frameworks-devel
mailing list