Review Request 112556: Move itemviews to tier2

Aurélien Gâteau agateau at kde.org
Tue Sep 10 10:45:55 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112556/
-----------------------------------------------------------

(Updated Sept. 10, 2013, 12:45 p.m.)


Review request for KDE Frameworks.


Changes
-------

Regenerated diff using --find-copies-harder


Description
-------

In itemviews/CMakeLists.txt: I took the find_package(Qt5) out of the
if (NOT kdelibs_SOURCE_DIR) test otherwise it would not build within
kdelibs.


Diffs (updated)
-----

  staging/CMakeLists.txt f0b6bf0 
  staging/itemviews/CMakeLists.txt f5c3c8d 
  staging/itemviews/ItemViewsConfig.cmake.in  
  staging/itemviews/autotests/CMakeLists.txt  
  staging/itemviews/autotests/klistwidgetsearchlinetest.cpp  
  staging/itemviews/src/CMakeLists.txt  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.h  
  staging/itemviews/src/kcategorizedsortfilterproxymodel.cpp  
  staging/itemviews/src/kcategorizedsortfilterproxymodel_p.h  
  staging/itemviews/src/kcategorizedview.h  
  staging/itemviews/src/kcategorizedview.cpp  
  staging/itemviews/src/kcategorizedview_p.h  
  staging/itemviews/src/kcategorydrawer.h  
  staging/itemviews/src/kcategorydrawer.cpp  
  staging/itemviews/src/kextendableitemdelegate.h  
  staging/itemviews/src/kextendableitemdelegate.cpp  
  staging/itemviews/src/kfilterproxysearchline.h  
  staging/itemviews/src/kfilterproxysearchline.cpp  
  staging/itemviews/src/klistwidgetsearchline.h  
  staging/itemviews/src/klistwidgetsearchline.cpp  
  staging/itemviews/src/ktreewidgetsearchline.h  
  staging/itemviews/src/ktreewidgetsearchline.cpp  
  staging/itemviews/src/kwidgetitemdelegate.h  
  staging/itemviews/src/kwidgetitemdelegate.cpp  
  staging/itemviews/src/kwidgetitemdelegate_p.h  
  staging/itemviews/src/kwidgetitemdelegatepool.cpp  
  staging/itemviews/src/kwidgetitemdelegatepool_p.h  
  staging/itemviews/tests/CMakeLists.txt  
  staging/itemviews/tests/kcategorizedviewtest.cpp  
  staging/itemviews/tests/ktreewidgetsearchlinetest.h  
  staging/itemviews/tests/ktreewidgetsearchlinetest.cpp  
  staging/itemviews/tests/kwidgetitemdelegatetest.cpp  
  tier2/CMakeLists.txt 62faacb 

Diff: http://git.reviewboard.kde.org/r/112556/diff/


Testing
-------

Builds and passes tests when build from kdelibs and standalone.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130910/d1ab5335/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list