Review Request 112560: Remove KNotification dependency in KCompletion

[Sune Vuorela]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112560/#review39651
-----------------------------------------------------------

Ship it!


Ship It!

- Sune Vuorela


On Sept. 6, 2013, 3:04 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112560/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 3:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Drop KNotifications dependency from KCompletion.
> 
> Reasons:
> - Its not used in KDE4
> - It creates noise
> - It bumps KCompletion from tier2 to tier3
> 
> I know I already sent an e-mail about it, but it seemed to me that a review request would be more welcome.
> 
> 
> Diffs
> -----
> 
>   staging/kcompletion/src/CMakeLists.txt 1300ab5 
>   staging/kcompletion/src/kcompletion.cpp bcd220a 
>   staging/kcompletion/src/khistorycombobox.cpp fe955a2 
> 
> Diff: http://git.reviewboard.kde.org/r/112560/diff/
> 
> 
> Testing
> -------
> 
> builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/59454a51/attachment.html>