Review Request 112532: Extend KShortcutsEditor by an actionTypes property

Commit Hook null at kde.org
Mon Sep 9 04:29:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112532/#review39619
-----------------------------------------------------------


This review has been submitted with commit 4dffa921c9dee5f97ad4a58ced2c3d2df24cfb61 by Martin Gräßlin to branch frameworks.

- Commit Hook


On Sept. 5, 2013, 6:46 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112532/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 6:46 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This change allows to change the action types of the KShortcutsEditor after being created. This is useful as a default created widget (e.g. through ui file) will have all action types enabled and does not allow to reduce to just global actions.
> 
> 
> Diffs
> -----
> 
>   staging/xmlgui/src/kshortcutsdialog_p.h b70b385 
>   staging/xmlgui/src/kshortcutseditor.h 5b90f74 
>   staging/xmlgui/src/kshortcutseditor.cpp 22aa016 
> 
> Diff: http://git.reviewboard.kde.org/r/112532/diff/
> 
> 
> Testing
> -------
> 
> Changed one of KWin's effect configuration to use the KShortcutsEditor instead of our global subclass. Works.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/f3282c69/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list