Review Request 112499: Rework finding of XCB

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112499/#review39618
-----------------------------------------------------------


This review has been submitted with commit 97ce3dc808ca616445d8f389b9a00d58e518494b by Martin Gräßlin to branch master.

- Commit Hook


On Sept. 4, 2013, 5:20 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112499/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 5:20 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Description
> -------
> 
> Rework finding of XCB
> 
> Uses the new components syntax of FindXCB. So far plasma frameworks
> only need the XCB component and that one is optional just like XLib.
> 
> The find xcb is moved to the toplevel CMakeLists.txt together with
> the find x11 and HAVE_X11 gets set only if both X11 and XCB are found.
> 
> Note: requires https://git.reviewboard.kde.org/r/112151/ in ECM
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 84a79114bedc40d315fd110bb176855b0c0db76a 
>   src/declarativeimports/core/CMakeLists.txt 12c06901b51cd85f2a5e47599bf7a579e8d4d476 
>   src/shell/CMakeLists.txt 5e2fec4b2f0b06f7f6fee3963f730a34f5d03836 
> 
> Diff: http://git.reviewboard.kde.org/r/112499/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130909/7a38f752/attachment.html>