Review Request 112547: avoid creating jobs on urls with double slashes
David Faure
faure at kde.org
Sun Sep 8 13:13:47 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112547/#review39581
-----------------------------------------------------------
Please test https://codereview.qt-project.org/64926, it should make this fix unnecessary.
- David Faure
On Sept. 5, 2013, 6:53 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112547/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 6:53 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> It happens that sometimes urls get a double shash instead of one, to trash:/foo becoming trash://foo (an hostname)
> this happens because if url.path() == "/"
> the line
> itemURL.setPath(itemURL.path() + '/' + fileName);
> just doubles the /
>
> I'm not sure the patch is correct, if path() is guaranteed to always have a trailing slash it may be simpler (altough qurl documentation doesn't suggest so)
>
>
> Diffs
> -----
>
> staging/kio/src/core/job.cpp e066ef4
>
> Diff: http://git.reviewboard.kde.org/r/112547/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130908/50d086b1/attachment.html>
More information about the Kde-frameworks-devel
mailing list