Review Request 112281: Allow setting a custom highligher on the spell check decorator

David Edmundson david at davidedmundson.co.uk
Fri Sep 6 17:54:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/
-----------------------------------------------------------

(Updated Sept. 6, 2013, 5:53 p.m.)


Review request for KDE Frameworks.


Changes
-------

Add documentation to all parts of SpellCheckDecorator

Change setHighlighter to not take ownership (Highlighter will only have the lifespan of the QTextEdit anyway)


Description
-------

Allow setting a custom highlighter on the spell check decorator

--

This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. 
This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit.


Diffs (updated)
-----

  tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d 
  tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 

Diff: http://git.reviewboard.kde.org/r/112281/diff/


Testing
-------

None - my KF5 setup has no dictionaries installed.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130906/cf669cba/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list