Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112559/#review39476
-----------------------------------------------------------



khtml/ecma/xmlhttprequest.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29092>

    Please re-read your own documentation for redirectUrl() :-)
    
    "empty in case no redirection has happened."
    
    You have to keep the URL in that case.



khtml/html/html_formimpl.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29093>

    same as above



khtml/khtml_part.cpp
<http://git.reviewboard.kde.org/r/112559/#comment29086>

    Why? If the job fails the temp file will stay around, with the current code.
    I'd just remove the setAutoRemove(false) and the manual-remove.


- David Faure


On Sept. 6, 2013, 3:10 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112559/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 3:10 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Port the rest of kdelibs-frameworks to KIO/Jobs
> 
> 
> Diffs
> -----
> 
>   khtml/ecma/xmlhttprequest.h 6edf708 
>   khtml/ecma/xmlhttprequest.cpp 565b489 
>   khtml/html/html_formimpl.cpp 1a16a77 
>   khtml/khtml_part.cpp 1833e4c 
>   kio/kfile/kpropertiesdialog.cpp 2d2f00e 
>   kross/ui/plugin.cpp f9f23f9 
> 
> Diff: http://git.reviewboard.kde.org/r/112559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130906/f7d12854/attachment.html>