Review Request 111938: Allow installing both qca2 and qca3
David Faure
faure at kde.org
Fri Sep 6 09:30:50 UTC 2013
> On Sept. 1, 2013, 5:16 p.m., David Faure wrote:
> > Looks fine to me.
>
> Ivan Romanov wrote:
> I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me.
Holy... and here I was, thinking I was doing something good by reviewing patches for QCA, for lack of reviewers/maintainers.
Fine, I will definitely stay out of QCA completely, it's not like I ever wanted to be involved with it.
It's all yours now.
When objecting to a patch, you might want to give a more detailed technical argumentation than "I don't agree", BTW.
But I don't care anymore for that argumentation, that's a discussion between you and Alexander.
About notifications: you were in the CC for the request, according to reviewboard. You might want to check which emails reviewboard has for you, or your mail setup.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111938/#review39088
-----------------------------------------------------------
On Sept. 3, 2013, 12:42 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111938/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2013, 12:42 p.m.)
>
>
> Review request for KDE Frameworks and Ivan Romanov.
>
>
> Description
> -------
>
> Use qt5 suffix for files by default when installing a Qt5 version of QCA
>
> This way coinstallation of Qt4 and Qt5 based QCA is possible by default
>
>
> Diffs
> -----
>
> CMakeLists.txt 8cff977
> src/CMakeLists.txt 037c9ff
> src/config-qca.h.cmake PRE-CREATION
> src/qca_plugin.cpp ad810b9
>
> Diff: http://git.reviewboard.kde.org/r/111938/diff/
>
>
> Testing
> -------
>
> Compiled and installed.
> creating a Qt5 package for openSuSE works fine
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130906/34a094ab/attachment.html>
More information about the Kde-frameworks-devel
mailing list