Review Request 112536: Move KUnitConversion to tier2

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112536/#review39419
-----------------------------------------------------------



staging/kdoctools/KDocToolsMacros.cmake
<http://git.reviewboard.kde.org/r/112536/#comment29040>

    Bad rebase?



staging/kunitconversion/KUnitConversionConfig.cmake.in
<http://git.reviewboard.kde.org/r/112536/#comment29041>

    You didn't look close enough at 
    
     gitk --author=steveire
    
    :)
    
    See commit 92acd71c769d46d479152356783e21a03bda25e2.
    
    You need to populate and use a REQUIRED_QT_VERSION variable.


- Stephen Kelly


On Sept. 5, 2013, 3:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112536/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 3:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> I had to tell it to find Qt specifically, nothing else.
> 
> 
> Diffs
> -----
> 
>   staging/CMakeLists.txt ae2cbf8 
>   staging/kdoctools/KDocToolsMacros.cmake b1a3457 
>   staging/kunitconversion/CMakeLists.txt 1346a00 
>   staging/kunitconversion/KUnitConversionConfig.cmake.in 73a5db3 
>   staging/kunitconversion/autotests/CMakeLists.txt  
>   staging/kunitconversion/autotests/categorytest.h  
>   staging/kunitconversion/autotests/categorytest.cpp  
>   staging/kunitconversion/autotests/convertertest.h  
>   staging/kunitconversion/autotests/convertertest.cpp  
>   staging/kunitconversion/autotests/valuetest.h  
>   staging/kunitconversion/autotests/valuetest.cpp  
>   staging/kunitconversion/src/CMakeLists.txt  
>   staging/kunitconversion/src/Mainpage.dox  
>   staging/kunitconversion/src/Messages.sh  
>   staging/kunitconversion/src/acceleration.h  
>   staging/kunitconversion/src/acceleration.cpp  
>   staging/kunitconversion/src/angle.h  
>   staging/kunitconversion/src/angle.cpp  
>   staging/kunitconversion/src/area.h  
>   staging/kunitconversion/src/area.cpp  
>   staging/kunitconversion/src/converter.h  
>   staging/kunitconversion/src/converter.cpp  
>   staging/kunitconversion/src/currency.h  
>   staging/kunitconversion/src/currency.cpp  
>   staging/kunitconversion/src/density.h  
>   staging/kunitconversion/src/density.cpp  
>   staging/kunitconversion/src/energy.h  
>   staging/kunitconversion/src/energy.cpp  
>   staging/kunitconversion/src/force.h  
>   staging/kunitconversion/src/force.cpp  
>   staging/kunitconversion/src/frequency.h  
>   staging/kunitconversion/src/frequency.cpp  
>   staging/kunitconversion/src/fuel_efficiency.h  
>   staging/kunitconversion/src/fuel_efficiency.cpp  
>   staging/kunitconversion/src/kcurrencycode.h  
>   staging/kunitconversion/src/kcurrencycode.cpp  
>   staging/kunitconversion/src/length.h  
>   staging/kunitconversion/src/length.cpp  
>   staging/kunitconversion/src/mass.h  
>   staging/kunitconversion/src/mass.cpp  
>   staging/kunitconversion/src/power.h  
>   staging/kunitconversion/src/power.cpp  
>   staging/kunitconversion/src/pressure.h  
>   staging/kunitconversion/src/pressure.cpp  
>   staging/kunitconversion/src/temperature.h  
>   staging/kunitconversion/src/temperature.cpp  
>   staging/kunitconversion/src/timeunit.h  
>   staging/kunitconversion/src/timeunit.cpp  
>   staging/kunitconversion/src/unit.h  
>   staging/kunitconversion/src/unit.cpp  
>   staging/kunitconversion/src/unitcategory.h  
>   staging/kunitconversion/src/unitcategory.cpp  
>   staging/kunitconversion/src/value.h  
>   staging/kunitconversion/src/value.cpp  
>   staging/kunitconversion/src/velocity.h  
>   staging/kunitconversion/src/velocity.cpp  
>   staging/kunitconversion/src/volume.h  
>   staging/kunitconversion/src/volume.cpp  
>   tier2/CMakeLists.txt 1f110e8 
> 
> Diff: http://git.reviewboard.kde.org/r/112536/diff/
> 
> 
> Testing
> -------
> 
> builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130905/e2edaf39/attachment-0001.html>