Review Request 112407: Port KJob to QEventLoopLocker

[Aurélien Gâteau]

> On Sept. 1, 2013, 10:11 a.m., David Faure wrote:
> > Testing that it compiles isn't enough, please test that the unittests still pass. :)
> > 
> > Too bad I can't find a test for this precise feature, but at least it would be good to check that nothing regresses.

Just checked tests do pass and committed. Did not add a test since we agreed on IRC writing a test for this feature is not doable within KCoreAddons.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112407/#review39047
-----------------------------------------------------------


On Sept. 5, 2013, 11:30 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112407/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 11:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port KJob to QEventLoopLocker
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.cpp d31c80b 
>   tier1/kcoreaddons/src/lib/jobs/kjob_p.h 6618fc4 
> 
> Diff: http://git.reviewboard.kde.org/r/112407/diff/
> 
> 
> Testing
> -------
> 
> It compiles
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130905/55b32523/attachment.html>