Review Request 112519: trim KStyle
Christoph Feck
christoph at maxiom.de
Wed Sep 4 22:20:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112519/#review39383
-----------------------------------------------------------
staging/frameworkintegration/src/kstyle/kstyle.h
<http://git.reviewboard.kde.org/r/112519/#comment29021>
Is this one still needed somewhere else?
staging/frameworkintegration/src/kstyle/kstyle.h
<http://git.reviewboard.kde.org/r/112519/#comment29020>
The "runtime element extension" should probably stay. They are useful, and Qt/QStyle does not offer anything similar.
(Actually, these static functions are what I proposed to move to a new namespace KStyle, but since it apparently has been decided to keep KStyle as a class, this does not work :)
Regarding the eventFilter, I would kill it. Making labels a click-buddy for other widgets should not depend on the used style, so if the feature is really needed, it should be proposed upstream.
Then you can also kill drawKStylePrimitive().
- Christoph Feck
On Sept. 4, 2013, 7:45 p.m., Wojciech Kapuscinski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112519/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 7:45 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> KStyle 2/3: Remove everything from KStyle which is not a reimplementation of the following methods: polish, unpolish, eventFilter, styleHint, pixelMetrics, standardIcons.
>
>
> Note:
> Probably we can remove drawKStylePrimitive (and a lot enums/structs in kstyle.h) but right now I'm unsure if I understand KStyle::eventFilter correctly and this is material for 3/3 KStyle task :)
>
>
> Diffs
> -----
>
> staging/frameworkintegration/src/kstyle/kstyle.h a3061d3
> staging/frameworkintegration/src/kstyle/kstyle.cpp 17a1d41
>
> Diff: http://git.reviewboard.kde.org/r/112519/diff/
>
>
> Testing
> -------
>
> It builds and tests looks OK
>
>
> Thanks,
>
> Wojciech Kapuscinski
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130904/d0492187/attachment.html>
More information about the Kde-frameworks-devel
mailing list