Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112479/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 4:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
-------

Split Bookmarks out of kio folder into own folder in staging.

This is simply a splitting + moving + removing deprecated functions, I am aware it doesn't comply with a lot of other things on the frameworks checklist yet.

It is possible to split kbookmarks into core + gui. Do we want that?

We also need to decide what tier this is aiming for. I think 3 as we use parts of KIO.


Diffs
-----

  kio/CMakeLists.txt 167f697 
  kio/bookmarks/kbookmark.h 2d06120 
  kio/bookmarks/kbookmark.cc beb82db 
  kio/bookmarks/kbookmarkdialog.h  
  kio/bookmarks/kbookmarkdialog.cc  
  kio/bookmarks/kbookmarkdialog_p.h  
  kio/bookmarks/kbookmarkdombuilder.h  
  kio/bookmarks/kbookmarkdombuilder.cc  
  kio/bookmarks/kbookmarkexporter.h  
  kio/bookmarks/kbookmarkimporter.h  
  kio/bookmarks/kbookmarkimporter.cc  
  kio/bookmarks/kbookmarkimporter_ie.h  
  kio/bookmarks/kbookmarkimporter_ie.cc  
  kio/bookmarks/kbookmarkimporter_ns.h  
  kio/bookmarks/kbookmarkimporter_ns.cc  
  kio/bookmarks/kbookmarkimporter_opera.h  
  kio/bookmarks/kbookmarkimporter_opera.cc  
  kio/bookmarks/kbookmarkimporter_opera_p.h  
  kio/bookmarks/kbookmarkmanager.h  
  kio/bookmarks/kbookmarkmanager.cc  
  kio/bookmarks/kbookmarkmanageradaptor.cc  
  kio/bookmarks/kbookmarkmanageradaptor_p.h  
  kio/bookmarks/kbookmarkmenu.h  
  kio/bookmarks/kbookmarkmenu.cc  
  kio/bookmarks/kbookmarkmenu_p.h  
  kio/bookmarks/konqbookmarkmenu.h  
  kio/bookmarks/konqbookmarkmenu.cc  
  kio/tests/CMakeLists.txt e9e7265 
  kio/tests/kbookmarkdialogtest.cpp  
  kio/tests/kbookmarktest.h  
  kio/tests/kbookmarktest.cpp  
  staging/CMakeLists.txt 1602d95 
  staging/kbookmarks/CMakeLists.txt PRE-CREATION 
  staging/kbookmarks/autotests/CMakeLists.txt PRE-CREATION 
  staging/kbookmarks/src/CMakeLists.txt PRE-CREATION 
  staging/kbookmarks/tests/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112479/diff/


Testing
-------

compiles  + test runs.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130904/7477407e/attachment.html>