Review Request 112485: Cleaning up KCompletion

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112485/#review39362
-----------------------------------------------------------

Ship it!



staging/kcompletion/src/klineedit.cpp
<http://git.reviewboard.kde.org/r/112485/#comment29003>

    Yes for now, but please add a Qt task to move this to QLineEdit.


- David Faure


On Sept. 3, 2013, 4:22 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112485/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 4:22 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Document dependencies, drop KCoreAddons and KIconLoader.
> Remove config.h file, figure out whether we're on X11 at runtime instead of at build time. We won't want to have separate kdelibs for X11 and Wayland.
> 
> Regarding the KNotifications dependency, I'd suggest to remove it (I would do it myself). At the moment it's generating quite a bit of DBus noise even though it's not being used elsewhere (in my system or Alex's it doesn't make any noise or show anything).
> It's used in KHistoryBox and KCompletion. If you want to test it, you can play with KRunner.
> 
> 
> Diffs
> -----
> 
>   staging/kcompletion/src/klineedit.cpp b2b430d 
>   staging/kcompletion/src/config-kcompletion.h.cmake 35b64a2 
>   staging/kcompletion/src/CMakeLists.txt f08a47d 
>   staging/kcompletion/src/klineedit_p.h 4d3cfbc 
> 
> Diff: http://git.reviewboard.kde.org/r/112485/diff/
> 
> 
> Testing
> -------
> 
> builds, tests pass
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130904/4a9a1565/attachment-0001.html>