Review Request 112495: Move kcrash to tier2

Martin Klapetek martin.klapetek at gmail.com
Tue Sep 3 20:35:13 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112495/
-----------------------------------------------------------

(Updated Sept. 3, 2013, 8:35 p.m.)


Review request for KDE Frameworks.


Description
-------

Removes the remove_definitions(..) from cmake, no code changes needed. KCrash however has no tests, I'm not sure how to test it properly (if someone can give me ideas, I'll try writing such tests).


Diffs (updated)
-----

  staging/CMakeLists.txt 3e4ec3a 
  staging/kcrash/CMakeLists.txt ce926ec 
  staging/kcrash/KCrashConfig.cmake.in  
  staging/kcrash/src/CMakeLists.txt 5dab9be 
  staging/kcrash/src/config-kcrash.h.cmake  
  staging/kcrash/src/config-strlcpy.h.cmake  
  staging/kcrash/src/kcrash.h  
  staging/kcrash/src/kcrash.cpp  
  staging/kcrash/src/strlcpy-fake.c  
  tier2/CMakeLists.txt bd5ea8c 

Diff: http://git.reviewboard.kde.org/r/112495/diff/


Testing
-------

Builds ok.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/a577dd89/attachment.html>


More information about the Kde-frameworks-devel mailing list