Review Request 112488: Fix isReadable() not handling edge case

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112488/#review39284
-----------------------------------------------------------

Ship it!


Wow, it even comes with a unit test :-) Great.

- David Faure


On Sept. 3, 2013, 4:40 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112488/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 4:40 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> This is a follow up to https://git.reviewboard.kde.org/r/112481
> 
> If a file we own is readable by others but not by ourself, isReadable() should return false.
> 
> 
> Diffs
> -----
> 
>   kio/tests/kfileitemtest.cpp 0658a77 
>   kio/tests/kfileitemtest.h a9a19f0 
>   staging/kio/src/core/kfileitem.cpp c997765 
> 
> Diff: http://git.reviewboard.kde.org/r/112488/diff/
> 
> 
> Testing
> -------
> 
> Added a new test to KFileItemTest. All KIO tests still pass.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/f066b6ec/attachment.html>