Review Request 112455: Remove any usage of KIO::NetAccess in kfile/

[Àlex Fiestas]

> On Sept. 3, 2013, 2 p.m., David Faure wrote:
> > kfile/kdirselectdialog.cpp, line 559
> > <http://git.reviewboard.kde.org/r/112455/diff/2/?file=186817#file186817line559>
> >
> >     return path.isEmpty() ? url : QUrl::fromLocalFile(path);
> >     
> >     would save 6 lines and increase readability (IMHO; feel free to disagree :) ).

Meh.. I like my conditionals big, but in this case ok.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112455/#review39264
-----------------------------------------------------------


On Sept. 3, 2013, 3 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112455/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 3 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Ported all remaining usages of KIO::NetAccess to Job+exec.
> 
> In one case I have added a new method in the Private because the code looked better.
> 
> 
> Diffs
> -----
> 
>   kfile/kdiroperator.cpp 72789ae 
>   kfile/kdirselectdialog.cpp 92cff2f 
>   kfile/kfileplacesmodel.cpp e854059 
>   kfile/kfilewidget.cpp f668039 
>   kfile/knewfilemenu.cpp 5e768b8 
> 
> Diff: http://git.reviewboard.kde.org/r/112455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/0d134d67/attachment.html>