Review Request 112151: Use components in FindXCB

[Stephen Kelly]

> On Aug. 27, 2013, 4:08 p.m., Stephen Kelly wrote:
> > find-modules/FindXCB.cmake, line 184
> > <http://git.reviewboard.kde.org/r/112151/diff/1/?file=183395#file183395line184>
> >
> >     I don't think 'NAMES lib' is correct. That will search for a lib named 'lib' with certain patterns, eg liblib.so.
> >     
> >     You should probably just remove the 'NAMES lib' part.
> >     
> >     The variable name here should be _LIBRARY.
> 
> Martin Gräßlin wrote:
>     ah that should have been NAMES ${_lib}. Concerning the variable name I wanted to keep the name of the variable as it used to be. It was LIBRARIES before - which was already incorrect. I would prefer to not change it as that would mean adjustments all over the place.

Then fix it and populate the other variable with set() below for compatibility.

I can't imagine adjustment all over the place is difficult in any way. That's what sed -i is for...


> On Aug. 27, 2013, 4:08 p.m., Stephen Kelly wrote:
> > find-modules/FindXCB.cmake, line 196
> > <http://git.reviewboard.kde.org/r/112151/diff/1/?file=183395#file183395line196>
> >
> >     Shouldn't this be _DIRS instead?
> 
> Martin Gräßlin wrote:
>     same as with the LIBRARIES. That's the name it used to have.

As above.


- Stephen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112151/#review38751
-----------------------------------------------------------


On Aug. 19, 2013, 9:39 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112151/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 9:39 a.m.)
> 
> 
> Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly.
> 
> 
> Description
> -------
> 
> Instead of finding all or nothing from XCB it becomes components aware. So a user can just specify which XCB components it needs and compilation doesn't fail if a not-needed unrelated component is not found. It also allows to have some components as required and some as optional.
> 
> 
> Diffs
> -----
> 
>   find-modules/FindXCB.cmake 7e7e701 
> 
> Diff: http://git.reviewboard.kde.org/r/112151/diff/
> 
> 
> Testing
> -------
> 
> tested in kde-workspace
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130903/5b8c620d/attachment.html>